Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release_notes from process #802

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

davidmrdavid
Copy link
Contributor

@davidmrdavid davidmrdavid commented Apr 22, 2022

Issue describing the changes in this PR

From my last conversation with @Francisco-Gamino, I understood that we were dropping the use of release_notes.md from our PR-making process. Assuming I understand that correctly, I made this PR to remove the release_notes.md file from the repo, as well as removing the instruction to use it in our PR-making template.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

@Francisco-Gamino
Copy link
Contributor

@AnatoliB / @michaelpeng36 -- In our current release process, we manually generate the release notes. Do you have any concerns with this change?

Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for Anatoli's and Michael's feedback before merging this change.

@michaelpeng36
Copy link
Contributor

@Francisco-Gamino @davidmrdavid, I think release_notes.md are primarily useful when it's hard to keep track of the work that was done since the last release. If we have been manually generating release notes for PowerShell worker releases up until this point without any issue, then this change seems like a good way to move forward to me.

@AnatoliB
Copy link
Contributor

I'm ok either way. As far as I understand, unlike some other repos, this repo does not have automation to generate release notes automatically from a file today. I think it would be great to get there eventually, perhaps as a part of automating the worker release pipeline in general. But, since this is not implemented today, we can clean it up for now, just to avoid a confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants