Skip to content

Blob extension code coverage improvements #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Blob extension code coverage improvements #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c13e8de
extra tests for BlobClientConverter
Mar 27, 2024
80527ad
Merge branch 'dev' into hallvictoria/blob-code-cov
hallvictoria Mar 27, 2024
cc3d674
merge with dev
Mar 27, 2024
44a0c81
Merge branch 'hallvictoria/blob-code-cov' of https://github.com/Azure…
Mar 27, 2024
bdfc6f6
Merge branch 'dev' into hallvictoria/blob-code-cov
hallvictoria Mar 27, 2024
a7cb119
lint
Mar 27, 2024
c9eade4
merge with dev
Mar 27, 2024
b5e1c3e
test_ssd lint miss
Mar 27, 2024
e4630f5
Merge branch 'dev' into hallvictoria/blob-code-cov
gavin-aguiar Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions azure-functions-extension-blob/tests/test_blobclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ def test_input_none(self):
)
self.assertIsNone(result)

datum: Datum = Datum(value=b"string_content", type=None)
result = BlobClientConverter.decode(
data=datum, trigger_metadata=None, pytype=BlobClient
)
self.assertIsNone(result)

def test_input_incorrect_type(self):
datum: Datum = Datum(value=b"string_content", type="bytearray")
with self.assertRaises(ValueError):
Expand Down Expand Up @@ -119,6 +125,27 @@ def test_input_populated(self):
self.assertIsNotNone(sdk_result)
self.assertIsInstance(sdk_result, BlobClientSdk)

def test_input_invalid_pytype(self):
content = {
"Connection": "AzureWebJobsStorage",
"ContainerName": "test-blob",
"BlobName": "text.txt",
}

sample_mbd = MockMBD(
version="1.0",
source="AzureStorageBlobs",
content_type="application/json",
content=json.dumps(content),
)

datum: Datum = Datum(value=sample_mbd, type="model_binding_data")
result: BlobClient = BlobClientConverter.decode(
data=datum, trigger_metadata=None, pytype="str"
)

self.assertIsNone(result)

def test_blob_client_invalid_creation(self):
# Create test binding
mock_blob = MockBinding(
Expand Down
27 changes: 27 additions & 0 deletions azure-functions-extension-blob/tests/test_containerclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ def test_input_none(self):
)
self.assertIsNone(result)

datum: Datum = Datum(value=b"string_content", type=None)
result = BlobClientConverter.decode(
data=datum, trigger_metadata=None, pytype=ContainerClient
)
self.assertIsNone(result)

def test_input_incorrect_type(self):
datum: Datum = Datum(value=b"string_content", type="bytearray")
with self.assertRaises(ValueError):
Expand Down Expand Up @@ -117,6 +123,27 @@ def test_input_populated(self):
self.assertIsNotNone(sdk_result)
self.assertIsInstance(sdk_result, ContainerClientSdk)

def test_input_invalid_pytype(self):
content = {
"Connection": "AzureWebJobsStorage",
"ContainerName": "test-blob",
"BlobName": "text.txt",
}

sample_mbd = MockMBD(
version="1.0",
source="AzureStorageBlobs",
content_type="application/json",
content=json.dumps(content),
)

datum: Datum = Datum(value=sample_mbd, type="model_binding_data")
result: ContainerClient = BlobClientConverter.decode(
data=datum, trigger_metadata=None, pytype="str"
)

self.assertIsNone(result)

def test_container_client_invalid_creation(self):
# Create test binding
mock_blob = MockBinding(
Expand Down
27 changes: 27 additions & 0 deletions azure-functions-extension-blob/tests/test_ssd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ def test_input_none(self):
)
self.assertIsNone(result)

datum: Datum = Datum(value=b"string_content", type=None)
result = BlobClientConverter.decode(
data=datum, trigger_metadata=None, pytype=StorageStreamDownloader
)
self.assertIsNone(result)

def test_input_incorrect_type(self):
datum: Datum = Datum(value=b"string_content", type="bytearray")
with self.assertRaises(ValueError):
Expand Down Expand Up @@ -119,6 +125,27 @@ def test_input_populated(self):
self.assertIsNotNone(sdk_result)
self.assertIsInstance(sdk_result, SSDSdk)

def test_input_invalid_pytype(self):
content = {
"Connection": "AzureWebJobsStorage",
"ContainerName": "test-blob",
"BlobName": "text.txt",
}

sample_mbd = MockMBD(
version="1.0",
source="AzureStorageBlobs",
content_type="application/json",
content=json.dumps(content),
)

datum: Datum = Datum(value=sample_mbd, type="model_binding_data")
result: StorageStreamDownloader = BlobClientConverter.decode(
data=datum, trigger_metadata=None, pytype="str"
)

self.assertIsNone(result)

def test_ssd_invalid_creation(self):
# Create test binding
mock_blob = MockBinding(
Expand Down