Enabling implicit output for generic bindings #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrdmr
requested review from
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1348 +/- ##
==========================================
- Coverage 85.97% 85.72% -0.26%
==========================================
Files 34 34
Lines 1940 1940
Branches 367 367
==========================================
- Hits 1668 1663 -5
- Misses 204 209 +5
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pdthummar
approved these changes
Nov 8, 2023
gavin-aguiar
approved these changes
Nov 13, 2023
…eturn' into vameru/implicit-output-binding-return
vrdmr
commented
Nov 14, 2023
| @@ -131,7 +131,7 @@ async def test_mock_generic_should_not_support_implicit_output(self): | |||
| protos.StatusResult.Success) | |||
|
|
|||
| _, r = await host.invoke_function( | |||
| 'foobar_as_bytes_no_anno', [ | |||
| 'foobar_implicit_output', [ | |||
There was a problem hiding this comment.
This is just fixing the incorrect test
gavin-aguiar
pushed a commit
that referenced
this pull request
Dec 1, 2023
This reverts commit a981fcf.
gavin-aguiar
added a commit
that referenced
this pull request
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling implicit binding for generic bindings.
PR information
Quality of Code and Contribution Guidelines