Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python specific app setting logs added #1353

Merged
merged 18 commits into from
Nov 14, 2023
Merged

Conversation

hallvictoria
Copy link
Contributor

Description

Adds an additional log statement to init and env reload request. This log statement details the state of the 6 python-specific app settings.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria marked this pull request as ready for review November 13, 2023 23:46
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d4200f8) 85.97% compared to head (1f14240) 32.15%.

❗ Current head 1f14240 differs from pull request most recent head 437cefe. Consider uploading reports for the commit 437cefe to get more accurate results

Files Patch % Lines
...zure_functions_worker/utils/app_setting_manager.py 33.33% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1353       +/-   ##
===========================================
- Coverage   85.97%   32.15%   -53.83%     
===========================================
  Files          34       35        +1     
  Lines        1940     1953       +13     
  Branches      367      370        +3     
===========================================
- Hits         1668      628     -1040     
- Misses        204     1324     +1120     
+ Partials       68        1       -67     
Flag Coverage Δ
unittests 32.15% <46.66%> (-53.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria self-assigned this Nov 14, 2023
azure_functions_worker/constants.py Outdated Show resolved Hide resolved
azure_functions_worker/constants.py Outdated Show resolved Hide resolved
azure_functions_worker/constants.py Outdated Show resolved Hide resolved
azure_functions_worker/dispatcher.py Show resolved Hide resolved
azure_functions_worker/utils/app_settings_logs.py Outdated Show resolved Hide resolved
azure_functions_worker/utils/app_settings_logs.py Outdated Show resolved Hide resolved
azure_functions_worker/utils/app_settings_logs.py Outdated Show resolved Hide resolved
azure_functions_worker/utils/app_settings_logs.py Outdated Show resolved Hide resolved
@gavin-aguiar gavin-aguiar merged commit 56f5caf into dev Nov 14, 2023
53 checks passed
@gavin-aguiar gavin-aguiar deleted the hallvictoria/appsetting-logs branch November 14, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants