Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactoring deferred bindings tests #1555

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Aug 2, 2024

Description

  • refactors deferred bindings tests into separate test files
  • updates condition for setting env var to branch name / pipeline variable
  • removes unused variable in test_dispatcher
  • skips build stage for public build if testing library / extension
  • skips unit tests if testing library / extension
  • skips install dependencies stage for LC if testing library / extension
  • adds retries for flaky print logging flush tests

Skipping build / install dependencies stage is done because those stages will fail as pyproject.toml contains the updated (and unreleased) library version.

Skipping unit tests is done because the public pipeline does not have access to download the library artifact from internal.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria marked this pull request as ready for review August 5, 2024 15:34
@hallvictoria hallvictoria merged commit 692aba1 into dev Aug 5, 2024
28 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/misc-pipeline-fixes branch August 5, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants