Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unique function names #1557

Merged
merged 12 commits into from
Aug 8, 2024
Merged

fix: unique function names #1557

merged 12 commits into from
Aug 8, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Aug 6, 2024

Description

  • Refactors variables into template file to prevent duplicate code. Adding variables can now be done in one spot
    • Variables.yml holds variables that can be used in public piplines
    • Official-variables.yml holds variables that can be used in internal pipelines
  • Removes -U flag when installing test sdk / extensions
    • Addresses an issue where, after installing the test version, the version specified in pyproject.toml was installed and overwrote the test version
  • Refactors deferred bindings unit tests
    • Moves to 1 single file
    • Deletes the function_app module after each test to prevent caching error
    • Fixes dispatcher unit tests
  • Deletes the function_app module after each test to prevent caching error

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria marked this pull request as ready for review August 7, 2024 19:37
@hallvictoria hallvictoria merged commit 2f8f424 into dev Aug 8, 2024
25 of 27 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/db-test-fixes branch August 8, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants