-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RabbitMQ client version to 6.2.2 #174
Conversation
85172c9
to
abf30a3
Compare
abf30a3
to
de18bfb
Compare
@@ -26,7 +27,7 @@ public interface IRabbitMQModel | |||
|
|||
void BasicReject(ulong deliveryTag, bool requeue); | |||
|
|||
void BasicPublish(string exchange, string routingKey, IBasicProperties basicProperties, byte[] body); | |||
void BasicPublish(string exchange, string routingKey, IBasicProperties basicProperties, ReadOnlyMemory<byte> body); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This interface is public. So, changing the method signature will be a breaking change for anyone using this API. Do you know who uses this?
Do we need this change? If so, should we do it in a backward compatible way? (Introduce a new overload and mark the old one as obsolete).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no public class that accepts IRabbitMQModel
as its method argument or has IRabbitMQModel
as return type. The only path where I could find the model definition leaking was via IRabbitMQModel
<- IRabbitMQService
<-IRabbitMQServiceFactory
but it stops at that point. There are no public classes taking or returning either IRabbitMQService
or IRabbitMQServiceFactory
or any of their implementation classes. I guess customer would not be impacted if they cannot work with IRabbitMQModel
in connection with any other classes in RabbitMQ extension. I will fix the visibility of the classes and interfaces in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the public API surface.
The general guidance is to introduce newer rabbitmq client version updates (major version updates) through a new major version of the extension. |
de18bfb
to
34ba280
Compare
Following the same tradition as of other Azure Functions repo, I will fork out |
A manual version bump is not required with new build and release pipeline.
5.1.2
to6.2.2
.6.2.2
client.Fixes #173, #92