Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SSL for AMQP connection #178

Merged
merged 11 commits into from
Feb 2, 2022
Merged

Allow SSL for AMQP connection #178

merged 11 commits into from
Feb 2, 2022

Conversation

aaguilartablada
Copy link
Contributor

In order to connect to an AMQPS endpoint a new attribute is necessary to configure 'SslOption' for 'ConnectionFactory'.
Furthermore, to allow using self-signed certificates for development environments another attribute has been introduced: 'InsecureSsl'.
By default, SslOption does NOT enable SNI extension (https://en.wikipedia.org/wiki/Server_Name_Indication). To enable it, setting the property 'ServerName' is enough. This extension is mandatory to allow connecting to several RabbitMQ clusters behind a load balancer.

@ghost
Copy link

ghost commented Jan 13, 2022

CLA assistant check
All CLA requirements met.

@aaguilartablada
Copy link
Contributor Author

@yojagad @JatinSanghvi Hello! Could you take a look at this PR, please? Thank you so much.

src/Utility.cs Outdated Show resolved Hide resolved
src/Trigger/RabbitMQTriggerAttribute.cs Show resolved Hide resolved
src/Services/RabbitMQService.cs Show resolved Hide resolved
@JatinSanghvi
Copy link
Contributor

This will also require updating RabbitMQOutput.java, RabbitMQTrigger.java and respective test cases.

@ghost ghost removed the Needs: Author Feedback label Feb 1, 2022
@aaguilartablada
Copy link
Contributor Author

Changes requested done and Java files updated. Thanks for your review @JatinSanghvi

@JatinSanghvi JatinSanghvi merged commit ad53e12 into Azure:dev Feb 2, 2022
@JatinSanghvi
Copy link
Contributor

Thanks @aaguilartablada, I have approved the pull request. If possible, I would like to know how frequently you need to supply individual tokens (hostname, username, password, port, ssl) instead of just the connection string. Most of other extensions are allowing just connection string to be passed.

@aaguilartablada
Copy link
Contributor Author

Thaks so much @JatinSanghvi. I use connection string, but I applied the changes in this PR also for individual tokens in case someone using them need to configure SSL this way.

When do you plan to release a new version including these changes? Thanks.

@JatinSanghvi
Copy link
Contributor

I am planning to get 2.0.0-preview1 released this week if everything goes well. The release will unblock users who are encountering issue #173. This would be a pre-release as there are more breaking changes planned for future releases. I am thinking of only retaining connection string since the attribute properties and internal method signatures are getting complex with introduction of new connection-string elements (next one in sequence was going to be a vhost property).

@aaguilartablada
Copy link
Contributor Author

Perfect! Thanks again. Good luck ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants