Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StyleCop suppressions and resolve style issues #194

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

JatinSanghvi
Copy link
Contributor

Adhering to default StyleCop recommendations i.e., using this. in front of the instance variables. This way is more consistent since otherwise we use variables with names like _varName for private instance fields, and names like VarName for public and private static fields and public instance properties. When referencing one of these variables in rest of the class, having this. prefixed makes it clear to the reader whether instance or static or local variable is being accessed. In that case, the underscore prefix becomes irrelevant. Similar justification can be found in StyleCop documentation here and here.

@JatinSanghvi JatinSanghvi requested a review from v-shenoy as a code owner April 19, 2022 18:29
Copy link
Member

@v-shenoy v-shenoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JatinSanghvi JatinSanghvi merged commit e100c19 into Azure:dev Apr 20, 2022
@JatinSanghvi JatinSanghvi deleted the stylecop branch April 20, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants