Enable logging for all tests and rename samples-csharpscript #823
+33
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
lucyzhang929,
chlafreniere,
MaddyDev and
VasuBhog
as code owners
|
Is there a reason why you have created against release/trigger branch and not main? These changes are not exactly related to trigger stuff. FYI I also have a PR out #812 to address some csx clean up against main - merging can get messy. |
|
Fair - the failing tests were the trigger ones (I don't believe we have any Input/Output tests that rely on messages like the trigger tests) so that's why I did them here, but you're right about the merging so let me open up an initial PR in main and then I can port it over + make the rest of the updates as a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSX tests are failing because they don't have the log level set to the correct level (that message is sent at the Debug level). So fixing that and added the log level to the other tests/samples that don't have it so all our tests/samples have the same settings.
I'm also renaming samples-csharpscript to samples-csx to match the test-csx folder we already have.