merge csx clean up #833
Merged
merge csx clean up #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sql attribute not needed * simplify the folder structure for csx * add local.settings.json * rename folders in proj file * clean up logs and unused
MaddyDev
requested review from
Charles-Gagnon,
lucyzhang929,
chlafreniere and
VasuBhog
as code owners
Charles-Gagnon
approved these changes
Apr 26, 2023
|
@MaddyDev I'll handle merging this in once the checks pass since we currently have to enable merge commits temporarily to ensure we keep the history. |
|
Test failures were all due to the logging issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #812 to trigger branch and also clean up the trigger samples.
Complete the trigger docs section for csx.