Skip to content

Commit

Permalink
Add node 20 as a hidden and preview Functions app stack (#7291)
Browse files Browse the repository at this point in the history
* add node 20 as a preview and hidden stack

* add eol date

* remove LTS
  • Loading branch information
hossam-nasr authored Aug 24, 2023
1 parent 56e416d commit 4033b5c
Show file tree
Hide file tree
Showing 2 changed files with 60 additions and 1 deletion.
59 changes: 59 additions & 0 deletions server/src/stacks/2020-10-01/stacks/function-app-stacks/Node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,74 @@ const getNodeStack: (useIsoDateFormat: boolean) => FunctionAppStack = (useIsoDat
const node10EOL = getDateString(new Date(2021, 3, 30), useIsoDateFormat);
const node8EOL = getDateString(new Date(2019, 11, 31), useIsoDateFormat);
const node6EOL = getDateString(new Date(2019, 3, 30), useIsoDateFormat);
const node20EOL = getDateString(new Date(2026, 4, 30), useIsoDateFormat);
const node18EOL = getDateString(new Date(2025, 3, 30), useIsoDateFormat);
const node16EOL = getDateString(new Date(2023, 8, 11), useIsoDateFormat);
const node14EOL = getDateString(new Date(2023, 3, 30), useIsoDateFormat);


return {
displayText: 'Node.js',
value: 'node',
preferredOs: 'windows',
majorVersions: [
{
displayText: 'Node.js 20',
value: '20',
minorVersions: [
{
displayText: 'Node.js 20',
value: '20',
stackSettings: {
windowsRuntimeSettings: {
runtimeVersion: '~20',
isPreview: true,
isHidden: true,
remoteDebuggingSupported: false,
appInsightsSettings: {
isSupported: true,
},
gitHubActionSettings: {
isSupported: true,
supportedVersion: '20.x',
},
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
WEBSITE_NODE_DEFAULT_VERSION: '~20',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: true,
netFrameworkVersion: 'v6.0',
},
supportedFunctionsExtensionVersions: ['~4'],
endOfLifeDate: node20EOL,
},
linuxRuntimeSettings: {
runtimeVersion: 'Node|20',
isPreview: true,
isHidden: true,
remoteDebuggingSupported: false,
appInsightsSettings: {
isSupported: true,
},
gitHubActionSettings: {
isSupported: true,
supportedVersion: '20.x',
},
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: false,
linuxFxVersion: 'Node|20',
},
supportedFunctionsExtensionVersions: ['~4'],
endOfLifeDate: node20EOL,
},
},
},
],
},
{
displayText: 'Node.js 18',
value: '18',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function validateNodeStack(nodeStack) {
expect(nodeStack.displayText).to.equal('Node.js');
expect(nodeStack.value).to.equal('node');
expect(nodeStack.preferredOs).to.equal('windows');
expect(nodeStack.majorVersions.length).to.equal(7);
expect(nodeStack.majorVersions.length).to.equal(8);
expect(nodeStack).to.deep.equal(hardCodedNodeStack);
}

Expand Down

0 comments on commit 4033b5c

Please sign in to comment.