Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 20 as a hidden and preview Functions app stack #7291

Merged
merged 8 commits into from
Aug 24, 2023
Merged

Add node 20 as a hidden and preview Functions app stack #7291

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a50497
add node 20 as a preview and hidden stack
hossam-nasr Jul 15, 2023
67615b9
Merge branch 'dev' into node20
hossam-nasr Aug 15, 2023
727c6db
add eol date
hossam-nasr Aug 16, 2023
d82ebfc
remove LTS
hossam-nasr Aug 16, 2023
ff98e1b
Merge branch 'dev' into node20
hossam-nasr Aug 16, 2023
c4f457f
Merge branch 'dev' into node20
hossam-nasr Aug 18, 2023
b7dcb86
Merge branch 'dev' into node20
takyyon Aug 24, 2023
0f39f13
Merge branch 'dev' into node20
takyyon Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions server/src/stacks/2020-10-01/stacks/function-app-stacks/Node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,61 @@ const getNodeStack: (useIsoDateFormat: boolean) => FunctionAppStack = (useIsoDat
value: 'node',
preferredOs: 'windows',
majorVersions: [
{
displayText: 'Node.js 20',
value: '20',
minorVersions: [
{
displayText: 'Node.js 20',
value: '20 LTS',
hossam-nasr marked this conversation as resolved.
Show resolved Hide resolved
stackSettings: {
windowsRuntimeSettings: {
runtimeVersion: '~20',
isPreview: true,
isHidden: true,
remoteDebuggingSupported: false,
appInsightsSettings: {
isSupported: true,
},
gitHubActionSettings: {
isSupported: true,
supportedVersion: '20.x',
},
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
WEBSITE_NODE_DEFAULT_VERSION: '~20',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: true,
netFrameworkVersion: 'v6.0',
},
supportedFunctionsExtensionVersions: ['~4'],
},
linuxRuntimeSettings: {
runtimeVersion: 'Node|20',
isPreview: true,
isHidden: true,
remoteDebuggingSupported: false,
appInsightsSettings: {
isSupported: true,
},
gitHubActionSettings: {
isSupported: true,
supportedVersion: '20.x',
},
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: false,
linuxFxVersion: 'Node|20',
},
supportedFunctionsExtensionVersions: ['~4'],
hossam-nasr marked this conversation as resolved.
Show resolved Hide resolved
},
},
},
],
},
{
displayText: 'Node.js 18',
value: '18',
Expand Down
2 changes: 1 addition & 1 deletion server/src/tests/Stacks/2020-10-01/function-app/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function validateNodeStack(nodeStack) {
expect(nodeStack.displayText).to.equal('Node.js');
expect(nodeStack.value).to.equal('node');
expect(nodeStack.preferredOs).to.equal('windows');
expect(nodeStack.majorVersions.length).to.equal(7);
expect(nodeStack.majorVersions.length).to.equal(8);
expect(nodeStack).to.deep.equal(hardCodedNodeStack);
}

Expand Down