replacing monaco with ace editor #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingXue
approved these changes
Jun 11, 2020
YingXue
pushed a commit
that referenced
this pull request
Jun 25, 2020
YingXue
pushed a commit
that referenced
this pull request
Jul 21, 2020
YingXue
added a commit
that referenced
this pull request
Jul 21, 2020
* Local folder (#246) * enable read from local folder and add tests * electron only for local files * make route hiden if interface is not found * remove focus if value is filled * validate model if not retrieved from model repo; moved constants around (#247) * use @id to match dtdl not names (#250) * use @id to match dtdl not names * update strings * New discovery (#249) * discover end2e * add tests * add bit more tests and some old discovery mech cleanup * address comments wave1 * Implement dt get and add tests (#255) * implement dt get and add tests * update dt value type * Folder picker (#254) * workflow e2e * add tests * address comments * add a resouce key back * Patch dt (#256) * implement dt get and add tests * update dt value type * implement dt patch and tests * address comment * update per telemetry service update; fix property styles (#258) * Rkessler/semantic units (#259) Add Semantic units. * fix a build break (#261) * Rkessler/rpos (#262) Remove private repo. * Update json schema adaptor; integrate service update for json patch (#260) * remove tooltip from json schema form; fix map in object data converter * remove dataform refactor * integrate latest service change * Allow remove of public repo. (#263) * remove model on device; remove query on pnp info (#268) * fix command api path; recomment out validation before the api is ready (#273) * fix command api path; recomment out validation before the api is ready * update api endpoint * Reusable schema (#266) * implement reusable schema and add test * add mock data file * merge master in (#276) * Rkessler/refactor settings (#281) * replay (minus test fixes) * snapshot and test updates. * Clarify discard message. * Address comments. * Fix number of value 0 was not showing (#278) * allow showing number of value 0 * turn off validation when value is 0 for numbers and intergers * make validation less hacky * improve text, comment out things, version update (#283) * Rkessler/notify repo change (#285) * Cosmetic changes and add notification. * Test enhancements. * boost test coverage. * raise test coverage. * comment tune up. * update product name; added privacy statement (#286) * update readme with new images (#284) * render telemetry row with empty body (#287) * render telemetry row with empty body * inform users which files are invalid * address comments * Default component (#289) * support default component in ui * show default component's telemetry * address a few bugs opened (#288) * moving to React 16.13 and Router 5 (#290) * moving to fiber * fiber tests * removing unused imports * addressed review comments * addressed review comments * bug fix * fix telemetry issues Co-authored-by: yingxue <kalian1127@gmail.com> * css and null check (#291) * moving AddDevice to react-async-saga-reducer (#292) * moving AddDevice to react-async-saga-reducer * simplifying notification * addressed review comments * reduxless device list (#293) * Devicetwin refactor (#295) * initial commit * update test * rename folder * Direct method and device events (#296) * refactor direct method * refactor telemetry page * explicit import * reduxless module and cloud to device message (#294) * reduxless cloud to device message * reduxless module identity * rebasing with master * addressed review comments * moving on - goodbye redux (#302) * reduxless pnp * update tests * fix model definition * fix typo * move device identity and related to be reduxless * update tests * reduxless * update tests * fix telemetry and update tests * fix tests Co-authored-by: yingxue <kalian1127@gmail.com> * remove redux, reselect; Note: azureResource and iotHub folder is removed in this commit, when need to bring them back, this is the commit to refer to (#303) * Folder rename (#306) * remove device content folder * remove default exports * update tests * optimizing office-ui-fabric imports (#307) * optimizing office-ui-fabric imports * removing unused code * Localization (#308) * remove localization context * update test * replacing monaco with ace editor (#309) * Remove moment (#311) * remove momentjs and fix bugs and warnings * fix bugs and tests * use exact version * fix bug when switch hubs and others (#313) * moving to brace editor for MIT license (#314) * rebase from master * support root level component; fix the bug in connetion string area (#316) * update dataplane api version (#317) * add missing css style (#318) * add missing css style * exclude button click from header click event * debug console for useReactAsyncReducer (#319) * remove copy to clipboard for preview (#320) * remove dataplane parameter and active connection string (#321) * remove dataplane parameter and active connection string * address comment * state separation (#322) * remove replace op for dt patch (#323) * Fixe bugs from 0706 triage meeting (#325) * fix default telemetry filtering; command response validation; writable property ack validation * enable edit on model location input box * bug bash fixes round 1 (#327) * add digital twin view; remove warning message; show unsupported type of dtdl; allow direct method to accept non-json payload; disallow dataplane response without status code * fix notificaiton effect * event use state refactor; validation fixes for map type; checkbox false value (#329) * add a few more null check (#330) * some css debt paid (#331) * Merge telemetry (#334) * json patch don't like null being the value * add regex check for map key * merge device events pages and make system property toggle in realtime * css update for events; using pivot instead of custome * rebase from master and update readme * mock local time response Co-authored-by: chieftn <rkessler@microsoft.com> Co-authored-by: asrudra <33266774+asrudra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.