Phone as a Device support for QR code #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit f982a59 Author: Paul Montgomery <pamontg@microsoft.com> Date: Wed Oct 20 12:18:31 2021 -0700 When no desiredValue, pre load with any reported Value commit bfe43b6 Author: Paul Montgomery <pamontg@microsoft.com> Date: Fri Sep 24 17:12:21 2021 -0700 QR supporting tesxt and fix falsey reported ack values commit 6a8dc92 Author: Paul Montgomery <pamontg@microsoft.com> Date: Tue Aug 31 14:47:52 2021 -0700 Fix some tests commit 43da209 Author: Paul Montgomery <pamontg@microsoft.com> Date: Tue Aug 31 09:14:07 2021 -0700 Begin implementing extends commit 2dac2d2 Author: Paul Montgomery <pamontg@microsoft.com> Date: Fri Aug 20 09:47:47 2021 -0700 Update electron-builder and handle enums better commit b9ef12f Author: Paul Montgomery <pamontg@microsoft.com> Date: Mon Aug 2 10:02:33 2021 -0700 Add the QR code generating bits for mobile app
YingXue
reviewed
Nov 9, 2021
| deviceIdentity={state.identity} | ||
| /> | ||
| <br /> | ||
| <QrGenerationView |
There was a problem hiding this comment.
i am wondering if it should be a separate nav item. And are we going to update the readme or just keep it low profile?
YingXue
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the Azure IoT Explorer!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
npm run testcommand)