Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack, Electron update and vulnerability fixes #499

Merged
merged 9 commits into from
Apr 6, 2022

Conversation

c-ryan-k
Copy link
Member

A build system update to fix some outdated components and security vulnerabilities.


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the Azure IoT Explorer!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit tests?
  • Have all unit tests passed locally? (by running npm run test command)
  • Have you updated the README.md with new screenshots if significant changes have been made?
  • Have you update the package version if the current version in package.json is not higher than the version released?

@c-ryan-k c-ryan-k marked this pull request as ready for review March 30, 2022 19:02
@c-ryan-k c-ryan-k requested review from chieftn and vilit1 March 30, 2022 21:18
src/app/api/shared/utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chieftn chieftn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- good to see the updates to specs. Think we should snap package.json to convention though

package.json Outdated Show resolved Hide resolved
@c-ryan-k c-ryan-k requested review from chieftn and vilit1 April 5, 2022 18:54
@c-ryan-k c-ryan-k merged commit 7cbebfe into Azure:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants