fetchDevices() and update banner telemetry #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Banner Telemetry
FetchDevices() telemetry
c-ryan-k
reviewed
Jul 28, 2022
Comment on lines
+201
to
+209
| try { | ||
| const response = await request(DATAPLANE_CONTROLLER_ENDPOINT, dataPlaneRequest); | ||
| AppInsightsClient.getInstance()?.trackEvent({name: TELEMETRY_EVENTS.FETCH_DEVICES}, {status: response.status.toString(), statusText: response.statusText}); | ||
| const result = await dataPlaneResponseHelper(response); | ||
| return result; | ||
| } catch (e) { | ||
| AppInsightsClient.getInstance()?.trackEvent({name: TELEMETRY_EVENTS.FETCH_DEVICES}, {status: 'N/A', statusText: e.toString()}); | ||
| throw (e); | ||
| } |
There was a problem hiding this comment.
Just a thought for the future -
Seems like this method has use outside of just fetching devices (even though that's the only place it's used for now). Possibly in a future PR we could abstract this to a helper function that takes an endpoint, request, and telemetry type;
export const fetchWithTelemetry(endpoint: string, request: any, telemetryType: {enum_or_telemetry_type_TBD})
YingXue
approved these changes
Jul 29, 2022
|
Yes, I was originally using the init event to tell when my app refreshed within the log but I'm likely going to repurpose it for some actual one-time logging in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logging to collect data on the fetchDevices() server call and whether people interact with the update version banner
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the Azure IoT Explorer!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
npm run testcommand)