Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ying/remove cs #653

Closed
wants to merge 3 commits into from
Closed

Ying/remove cs #653

wants to merge 3 commits into from

Conversation

YingXue
Copy link
Member

@YingXue YingXue commented Mar 6, 2024


image
Remove connection strings saved in local storage.
Now the string is saved in the global context and will be automatically cleared out whenever the app gets closed.
As a result, all the service calls need connection string passed in through action's payload.
If by any chance, the string is lost while user is using the app, it will auto redirect user to the login page.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit tests?
  • Have all unit tests passed locally? (by running npm run test command)
  • Have you updated the README.md with new screenshots if significant changes have been made?
  • Have you update the package version if the current version in package.json is not higher than the version released?

@YingXue YingXue closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant