New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ying/accessibility #683

Merged

YingXue merged 3 commits into Azure:main from YingXue:ying/accessibility

Dec 13, 2024

Member

YingXue commented Dec 12, 2024

Replace react-smooth-dnd with dndkit, which has accessbility built in
Add underscore in breadcrumb for link
Give text in submenu enough of color contrast
Add missing aria label

If introducing new functionality or modified behavior, are they backed by unit tests?
Have all unit tests passed locally? (by running npm run test command)
Have you updated the README.md with new screenshots if significant changes have been made?
Have you update the package version if the current version in package.json is not higher than the version released?

YingXue added 3 commits

December 12, 2024 13:44


          fix a few accessibility issues

ae3ac5e


          fix a few accessibility issues 2

f54b00b


          package update

aeaf07f

thanashr self-requested a review

December 13, 2024 17:47

thanashr approved these changes

View reviewed changes

YingXue merged commit 048b1b7 into Azure:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet