feat: --mq-traces in support bundle operation #103
Conversation
| for namespace in namespaces: | ||
| try: | ||
| traces = get_traces(namespace=namespace, trace_ids=["!support_bundle!"]) | ||
| if traces: |
There was a problem hiding this comment.
nit - now that get_traces can return either a list of dicts or a list of tuples, do we need to typecheck its return value? Might even just be here, as the other reference to it is a straight return get_traces(...
There was a problem hiding this comment.
Added test coverage for the return value in the stats tests area.
If the wrong type gets returned, and the later accessing code here causes an exception it should get caught, and also, we have a backup exception handler at the support bundle runner level.
There was a problem hiding this comment.
Also thinking about the type check it would per list item since the outer most type is either list or None. I kind of like the exception handle to provide a hint of something going wrong. We can consider making it a warning to show outside of --debug.
There was a problem hiding this comment.
Let's discuss in subsequent PR.
--mq-tracesflag toaz iot ops support create-bundle.statscommand supports both fetching traces by--trace-idsor--trace-dir.