E4K V1A3 check updates #14
Conversation
renamed chainCount to partitions Added backend workers display
Broker Diagnostics resource changed to Diagnostic Services resource Moved broker diagnostics details into individual broker detail checks Removed diagnostic ref check Changed missing broker diagnostics from skip to warning
Added target conditions to diagnostics service eval Set error status if count of resources is not 1 Added evals for each diagnostic service resource adjusted indendation of broker diagnostics logic
| diag_service_spec_log_level = diag_service_resource_spec.get("logLevel") | ||
| diag_service_spec_max_data_storage_size = diag_service_resource_spec.get("maxDataStorageSize") | ||
| diag_service_spec_metrics_port = diag_service_resource_spec.get("metricsPort") | ||
| diag_service_spec_stale_data_timeout = diag_service_resource_spec.get("staleDataTimeoutSeconds") |
There was a problem hiding this comment.
should we have none checks (since the get will return None if the key doesn't exist and the message is still printed
There was a problem hiding this comment.
I don't think it's a bad idea to have defaults, though in this case I'd want to steer away from quantitative defaults like "0", but I think since these are just simple outputs (and not tracked as a target / required value) that something like None is ok in place of N/A or another filler value
There was a problem hiding this comment.
as long as
"Data Export Frequency: [bright_blue]None[/bright_blue] seconds"
is ok, then everything is good
| diagnostic_service_count = len(diagnostics_service_resources) | ||
|
|
||
| service_count_status = CheckTaskStatus.success.value | ||
| service_status_color = "green" |
There was a problem hiding this comment.
future task should put these colors into an enum to help explain what they mean:
success = green
warning = yellow
info/idk = blue
| target_name=target_brokers, | ||
| display=Padding( | ||
| backend_workers_desc.format(backend_workers_colored), | ||
| (0, 0, 0, 16), |
There was a problem hiding this comment.
future task of putting these tuples into enums (assuming everything follows (0,0,0,x)
|
lgtm - I will let you squash and merge |
Adds support for E4K v1a3 API:
ActiveAPI to v1a3broker_diagnosticchecks todiagnostic_servicechecks and updates logic / evalsThis project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to Azure Edge tooling!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
devormainare of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrcand.flake8rules? Look at the CI scripts for example usage.Azure Edge CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).