Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API management refactoring. #15

Merged
merged 8 commits into from
Jul 29, 2023
Merged

API management refactoring. #15

merged 8 commits into from
Jul 29, 2023

Conversation

digimaun
Copy link
Member

@digimaun digimaun commented Jul 28, 2023

Primary purpose of the PR is to simplify API management.

Highlights:

  • Refactor out of having to provide resource kinds per EdgeResourceApi instantiation. Instead EdgeResourceApi will determine resource kinds based on group/version against the target cluster.
  • Removed EdgeResource. Let's see if we really need that abstraction.
  • base cluster interaction functions do not have dependency on EdgeResourceApi or EdgeResource

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to Azure Edge tooling!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure Edge CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@digimaun digimaun marked this pull request as ready for review July 28, 2023 22:08
@digimaun digimaun merged commit 5422d35 into Azure:dev Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants