Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support bundle {process_resource} func parameter combine resource_api moniker and sub_group #214

Merged
merged 11 commits into from
Jun 4, 2024

Conversation

Elsie4ever
Copy link
Contributor

@Elsie4ever Elsie4ever commented May 10, 2024

Since support bundle will no longer only used for EdgeResourceApi resources, for example billing arc resources, or the upcoming azure arc namespace resources, {process_resource} func parameter is removing resource_api and sub_group, instead directly passing the directory path would make more sense


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to Azure IoT Operations tooling!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@Elsie4ever Elsie4ever changed the title refator: support bundle {process_resource} func parameter change from resource_api to moniker for folder name refactor: support bundle {process_resource} func parameter change from resource_api to moniker for folder name May 10, 2024
@Elsie4ever
Copy link
Contributor Author

int tests passed
image

@Elsie4ever Elsie4ever changed the title refactor: support bundle {process_resource} func parameter change from resource_api to moniker for folder name refactor: support bundle {process_resource} func parameter combine resource_api moniker and sub_group May 31, 2024
@Elsie4ever Elsie4ever marked this pull request as ready for review May 31, 2024 17:02
@Elsie4ever Elsie4ever requested a review from digimaun as a code owner May 31, 2024 17:02
@Elsie4ever
Copy link
Contributor Author

image

@Elsie4ever Elsie4ever merged commit 8837477 into Azure:dev Jun 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants