-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(support bundles): fix lnm support #230
Conversation
Just a general note that in addition to fixes for the tests, we should also write a few new test cases that present the issues we found to ensure they pass |
azext_edge/tests/edge/support/create_bundle_int/test_auto_int.py
Outdated
Show resolved
Hide resolved
azext_edge/tests/edge/support/create_bundle_int/test_lnm_int.py
Outdated
Show resolved
Hide resolved
azext_edge/tests/edge/support/create_bundle_int/test_lnm_int.py
Outdated
Show resolved
Hide resolved
This will require writing in scenarios for these test cases in the form of "I did xyz to cluster" rather than make sure that support bundle captures the cluster in the current state correctly. I will work on adding in init and post-deployment "scenario" fixtures in a future pr (but adding in lnm would be a good idea). |
we talked offline about the lnm instance is possible to be deployed into other namespaces and might be more than one, more importantly mq connector and topic maps can have similar logic(deployed into other namespaces and might be more than one), probably will need to follow up on this |
going to address this in another pr since there are multiple resources |
FIXES COMMING IN HOT FOR LNM
btw the comments from me are mostly to show what I changed as I take over the pr (evil laughter)
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to Azure IoT Operations tooling!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).