Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(support bundles): fix lnm support #230

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

Elsie4ever
Copy link
Contributor

@Elsie4ever Elsie4ever commented Jun 4, 2024

image

FIXES COMMING IN HOT FOR LNM

btw the comments from me are mostly to show what I changed as I take over the pr (evil laughter)


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to Azure IoT Operations tooling!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@Elsie4ever Elsie4ever changed the title fix: pipeline issues fix: pipeline integration test issues Jun 4, 2024
@c-ryan-k
Copy link
Member

c-ryan-k commented Jun 4, 2024

Just a general note that in addition to fixes for the tests, we should also write a few new test cases that present the issues we found to ensure they pass

@vilit1
Copy link
Contributor

vilit1 commented Jun 4, 2024

Just a general note that in addition to fixes for the tests, we should also write a few new test cases that present the issues we found to ensure they pass

This will require writing in scenarios for these test cases in the form of "I did xyz to cluster" rather than make sure that support bundle captures the cluster in the current state correctly.

I will work on adding in init and post-deployment "scenario" fixtures in a future pr (but adding in lnm would be a good idea).

@vilit1 vilit1 marked this pull request as ready for review June 4, 2024 22:56
@vilit1 vilit1 requested a review from digimaun as a code owner June 4, 2024 22:56
@vilit1 vilit1 changed the title fix: pipeline integration test issues test(support bundles): fix lnm support Jun 4, 2024
@Elsie4ever
Copy link
Contributor Author

we talked offline about the lnm instance is possible to be deployed into other namespaces and might be more than one, more importantly mq connector and topic maps can have similar logic(deployed into other namespaces and might be more than one), probably will need to follow up on this

@Azure Azure deleted a comment from Elsie4ever Jun 5, 2024
@vilit1
Copy link
Contributor

vilit1 commented Jun 5, 2024

we talked offline about the lnm instance is possible to be deployed into other namespaces and might be more than one, more importantly mq connector and topic maps can have similar logic(deployed into other namespaces and might be more than one), probably will need to follow up on this

going to address this in another pr since there are multiple resources

@vilit1 vilit1 merged commit 6ac5194 into Azure:dev Jun 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants