-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply detailed pod conditions check to all services #245
Merged
Elsie4ever
merged 6 commits into
Azure:feature/0.6.0
from
Elsie4ever:user/jiacju/check_pod_update
Jun 28, 2024
Merged
feat: apply detailed pod conditions check to all services #245
Elsie4ever
merged 6 commits into
Azure:feature/0.6.0
from
Elsie4ever:user/jiacju/check_pod_update
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elsie4ever
changed the title
feature: apply detailed pod conditions check to all services
feat: apply detailed pod conditions check to all services
Jun 25, 2024
digimaun
approved these changes
Jun 25, 2024
Elsie4ever
force-pushed
the
user/jiacju/check_pod_update
branch
5 times, most recently
from
June 27, 2024 00:25
751f7cf
to
3b600b6
Compare
Elsie4ever
force-pushed
the
user/jiacju/check_pod_update
branch
from
June 27, 2024 00:31
3b600b6
to
3fad896
Compare
digimaun
reviewed
Jun 27, 2024
digimaun
approved these changes
Jun 28, 2024
c-ryan-k
pushed a commit
to c-ryan-k/azure-iot-ops-cli-extension
that referenced
this pull request
Jul 3, 2024
* apply detailed pod conditions check to all services
c-ryan-k
pushed a commit
to c-ryan-k/azure-iot-ops-cli-extension
that referenced
this pull request
Jul 3, 2024
* apply detailed pod conditions check to all services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to Azure IoT Operations tooling!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
dev
ormain
are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv
. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrc
and.flake8
rules? Look at the CI scripts for example usage.Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).