Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use table view in pod check #303

Merged
merged 26 commits into from
Sep 13, 2024

Conversation

Elsie4ever
Copy link
Contributor

@Elsie4ever Elsie4ever commented Aug 12, 2024

update pod check display to use table view in detail level 1 and 2
0 will keep the same as before to summarize pod check in one line

level 0:
image

level 1:
image
image

level 2:
image
image

for pods does not have conditions property, it will look like:
image


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to Azure IoT Operations tooling!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@Elsie4ever
Copy link
Contributor Author

IT runs
image

@Elsie4ever Elsie4ever marked this pull request as ready for review August 13, 2024 21:56
@Elsie4ever Elsie4ever requested a review from digimaun as a code owner August 13, 2024 21:56
@Elsie4ever Elsie4ever changed the base branch from dev to feature/0.7.0 August 15, 2024 17:57
@c-ryan-k c-ryan-k self-assigned this Sep 4, 2024
@Elsie4ever
Copy link
Contributor Author

Talked with @c-ryan-k for some refactoring, will re open the pr once refactor done

@Elsie4ever Elsie4ever marked this pull request as draft September 5, 2024 01:24
@Elsie4ever Elsie4ever marked this pull request as ready for review September 9, 2024 18:18
azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved
Copy link
Member

@c-ryan-k c-ryan-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a final few questions / nits to make sure we've got everything covered :)

azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Show resolved Hide resolved
azext_edge/edge/providers/check/base/pod.py Outdated Show resolved Hide resolved

for pod in pods:
target_service_pod = f"pod/{pod.metadata.name}"
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember if this was always the case with this PR - but did this method display a "no pods" message? Or is that up to the individual CR check now that it's removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah now the no pod message will be under individual CR check, since we need the label to output the error message, meanwhile we don't want to pass the label down to evaluate_pod_health

@Elsie4ever Elsie4ever merged commit 419d0b7 into Azure:feature/0.7.0 Sep 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants