Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip crd capture when related api not deployed for support bundle #316

Merged
merged 11 commits into from
Aug 23, 2024

Conversation

Elsie4ever
Copy link
Contributor

@Elsie4ever Elsie4ever commented Aug 22, 2024

The current support bundle behavior is: report error when service api not found and skip to capture rest of the runtime resources like pods, services etc.

Update to continue try capture the runtime resources even no api found in cluster, however, crd will be skipped since it requires the api presentation

Add a warning when api not found to inform user the crd capture will be skipped
image

Also updated the unitest

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to Azure IoT Operations tooling!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@Elsie4ever
Copy link
Contributor Author

Manually tested the situation to change api group from edge_api and verified other runtime resources except crd still gets captured

For IT runs, I ran it on the cluster that does not have the cert manager(since that will make test fail and not related to this change, will do that in another pr)
image

@Elsie4ever Elsie4ever marked this pull request as ready for review August 22, 2024 21:53
@Elsie4ever Elsie4ever requested a review from digimaun as a code owner August 22, 2024 21:53
@Elsie4ever Elsie4ever merged commit 666641c into Azure:feature/0.7.0 Aug 23, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants