Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Follow up. Adds param validation pattern using template languageVersion 2 model. #332

Merged
merged 3 commits into from
Sep 5, 2024
Merged

refactor: Follow up. Adds param validation pattern using template languageVersion 2 model. #332

merged 3 commits into from
Sep 5, 2024

Conversation

digimaun
Copy link
Member

@digimaun digimaun commented Sep 5, 2024 •
edited
Loading

  • Starting application for int based parameters that define min / max.
  • Can be expanded as necessary.
  • One gap is error presents model config name rather than CLI parameter but IMO these are clear enough for this first go.
  • Fixes some issues in SR IT.

@digimaun digimaun marked this pull request as ready for review September 5, 2024 21:16
@digimaun digimaun merged commit 08336d5 into Azure:feature/0.7.0 Sep 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elsie4ever Elsie4ever Elsie4ever approved these changes

@c-ryan-k c-ryan-k c-ryan-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@digimaun @c-ryan-k @Elsie4ever