Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deviceregistry check and support bundle updates for 0.7.0 #343

Merged
merged 10 commits into from
Sep 12, 2024

Conversation

vilit1
Copy link
Contributor

@vilit1 vilit1 commented Sep 10, 2024

once I manage to get a cluster on a codespace, I will try out the support bundle int tests to make sure I am not crazy...

Updates include:

  • the device registry object to v1betav2. This will not include the discovered counterparts.
  • update the asset endpoint profile ref
  • update the asset to include datasets. Note that since the datasets will be created with the name of "" by DOE, and multi dataset support will not be included till post GA, using datasets[0].dataPoints overall.
  • support bundle did capture the assets + asset endpoints from the first change.

image
image
image

image


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to Azure IoT Operations tooling!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@vilit1 vilit1 requested a review from digimaun as a code owner September 10, 2024 17:19
@Elsie4ever
Copy link
Contributor

will there be a check for discovered asset?

@vilit1
Copy link
Contributor Author

vilit1 commented Sep 10, 2024

not for this release. Only for the next release

@Elsie4ever
Copy link
Contributor

lgtm since it's just updating api and new properties, note: once we have more time we can collapse the check more for summary and detail level

@vilit1 vilit1 merged commit 35d89fe into Azure:feature/0.7.0 Sep 12, 2024
16 checks passed
@vilit1 vilit1 deleted the asset_checks_update branch October 2, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants