Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: capture arccontainerstorage in support bundle #351

Merged

Conversation

Elsie4ever
Copy link
Contributor

@Elsie4ever Elsie4ever commented Sep 12, 2024

  1. added ESA resource in support bundle, added --svc acs option
  2. temperary skip test for orc, will address in the orc removal pr
    image

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to Azure IoT Operations tooling!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Intent for Production

  • It is expected that pull requests made to default or core branches such as dev or main are of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.

Basic expectations

  • If introducing new functionality or modified behavior, are they backed by unit and/or integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all the relevant unit and integration tests pass? i.e. pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set.
  • Have linter checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.
  • Have extraneous print or debug statements, commented out code-blocks or code-statements (if any) been removed from the surface area of changes?
  • Have you made an entry in HISTORY.rst which concisely explains your user-facing feature or change?

Azure IoT Operations CLI maintainers reserve the right to enforce any of the outlined expectations.

A PR is considered ready for review when all basic expectations have been met (or do not apply).

@Elsie4ever
Copy link
Contributor Author

IT runs
image

@Elsie4ever Elsie4ever changed the title feat: capture ESA in support bundle feat: capture arccontainerstorage in support bundle Sep 12, 2024
@Elsie4ever
Copy link
Contributor Author

latest IT runs
image

@Elsie4ever Elsie4ever marked this pull request as ready for review September 12, 2024 21:35
azext_edge/edge/_help.py Outdated Show resolved Hide resolved
azext_edge/edge/_help.py Outdated Show resolved Hide resolved
Copy link
Member

@digimaun digimaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about refactoring / simplifying tests for SB.

@Elsie4ever
Copy link
Contributor Author

We should think about refactoring / simplifying tests for SB.

got it, will do once we finish all the higher priority work item

@Elsie4ever Elsie4ever merged commit 75aa293 into Azure:feature/0.7.0 Sep 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants