Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused mq app label and document labels without aio prefixes #70

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: remove unused mq app label and document labels without aio prefixes #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions azext_edge/edge/providers/support/mq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,9 @@
logger = get_logger(__name__)

MQ_APP_LABELS = [
'broker',
'diagnostics',
'health-manager',
'aio-mq-diagnostics-service',
'broker', # aio-mq-dmqtt-frontend, aio-mq-dmqtt-backend, aio-mq-dmqtt-authentication
'diagnostics', # aio-mq-diagnostics-service
'health-manager', # aio-mq-dmqtt-health-manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh - isn't it fine if we have labels that are not used since the result is the same? The overall function may be less efficient but since services are not stable yet - they can re add/change labels...

this will be easier once we manage to convince one label (combination) per service

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our client code should reflect how the services works now vs how they might be updated in the future.

'aio-mq-operator',
'aio-mq-mqttbridge',
'aio-mq-datalake',
Expand Down
0 ...tests/edge/checks/test_e4k_checks_unit.py → .../tests/edge/checks/test_mq_checks_unit.py
View file
Open in desktop
File renamed without changes.