fix(iot-device): Update IoT Hub CONNACK timeout to be 60 seconds #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipsaMisra
requested review from
azabbasi,
barustum,
bikamani,
drwill-ms,
jamdavi,
timtay-microsoft and
vinagesh
as code owners
timtay-microsoft
approved these changes
Jun 18, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
reviewed
Jun 18, 2021
| @@ -26,7 +26,10 @@ public class MqttTransportSettings : ITransportSettings | |||
| private const int DefaultMaxPendingInboundMessages = 50; | |||
| private const QualityOfService DefaultPublishToServerQoS = QualityOfService.AtLeastOnce; | |||
| private const QualityOfService DefaultReceivingQoS = QualityOfService.AtLeastOnce; | |||
| private static readonly TimeSpan s_defaultConnectArrivalTimeout = TimeSpan.FromSeconds(10); | |||
|
|
|||
| // The CONNACK timeout has been chosen to be 60 seconds to be in alignment with the service implemented timeout for processing connection requests. | |||
There was a problem hiding this comment.
thank you for adding a code comment
drwill-ms
approved these changes
Jun 18, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is merged into
masterI'll cherry-pick this commit into our latest LTS branch.On a related note - the sdk's DPS MQTT transport logic currently does not implement any timeout for CONNECT packet.
Fix for #2043