Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
to
The reasoning here was 2 fold -
(1) The writable property update requests are usually the interesting bit in
ClientProperties
. But the previous design promoted theReportedFropmClient
properties to the top-level object. With this change in design, both the "reported" and "requested" properties are now present under their specific accessors.(2) With everything being a dictionary for node, having the client reported properties under
ClientProperties
directly makes iterating through the collection difficult. IteratingClientProperties
directly would give you all client reported properties + the writable property requests under aWritable
key. With this change in design, you can now iterate overReportedFromClient
andWritablePropertyRequests
separately.SubscribeToWritablePropertiesEventAsync
toSubscribeToWritablePropertyUpdateRequestsAsync
(this matches theWritablePropertyRequests
inClientProperties
.)master
instead).Microsoft.Azure.Devices.Client.Tests
toMicrosoft.Azure.Devices.Client.Test