Select correct AMQP link for a Module Twin v. and Edge Device #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdavi
changed the title
jamdavi
commented
Oct 22, 2021
jamdavi
commented
Oct 22, 2021
jamdavi
commented
Oct 22, 2021
jamdavi
commented
Oct 22, 2021
jamdavi
requested review from
abhipsaMisra,
azabbasi,
drwill-ms and
timtay-microsoft
as code owners
azabbasi
reviewed
Oct 22, 2021
azabbasi
reviewed
Oct 22, 2021
azabbasi
approved these changes
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
drwill-ms
reviewed
Oct 22, 2021
Co-authored-by: David R. Williamson <drwill@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…t-sdk-csharp into jamdavi/issue2099
…t-sdk-csharp into jamdavi/issue2099
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
…Device (Azure#2219) * Select correct AMQP link for a Module Twin v. and Edge Device. * Updating unit tests and removing additional projects for testing * Remove safe close sematics to keep client the same. * Remove underscore * Restore AmqpUnit completely, no changes needed here * Add note to IDelegatingHandler * Update iothub/device/src/IDelegatingHandler.cs Co-authored-by: David R. Williamson <drwill@microsoft.com> * Update iothub/device/src/IDelegatingHandler.cs Co-authored-by: David R. Williamson <drwill@microsoft.com> * Update iothub/device/src/ModuleClient.cs Co-authored-by: David R. Williamson <drwill@microsoft.com> * Update iothub/device/src/ModuleClient.cs Co-authored-by: David R. Williamson <drwill@microsoft.com> * Feedback * Adding assemblyinfo * Fixing isAnEdgeModule in comments * Remove new lines * Style fixes Co-authored-by: David R. Williamson <drwill@microsoft.com> * Style changes * Move all edge module tests and turn of parallel execution * Make IotHubConnectionString dictate if the ModuleClient is using a gateway * remove extra comment * remove line break * Fixing order of builder * Adding disable handler back Co-authored-by: David R. Williamson <drwill@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bug #2099 when creating a ModuleClient for a Module Twin using AMQP (not an Edge Module) the AmqpTransport would use an incorrect receiver link.
This PR addresses that error and introduces the ability for a DeviceClient and a ModuleClient to disconnect a receiver link over AMQP without closing the entire AMQP session. To get around this I've removed the
DisableReceiveMessageAsyncmethod from theAmqpTransportHandlerclass. This should help with #2218.