[DPS][Public Preview] Provisioniong Service SDK Update #3492
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessHuh
changed the title
|
Also, this feature is for private preview for now, isn't it? It shouldn't be merged to main then. Did you get any different info from Tim? |
ewertons
reviewed
Aug 8, 2025
| /// Linked Azure Device Registry credential policy name (optional). | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = "credentialPolicyName", DefaultValueHandling = DefaultValueHandling.Ignore)] | ||
| public string CredentialPolicyName { get; set; } |
There was a problem hiding this comment.
Is credentialPolicyName the only change expected, or there will be more? Are the signing certs also set through th DPS service API?
| @@ -18,6 +18,7 @@ public class EnrollmentGroupTests | |||
| private const string SampleLastUpdatedDateTimeUTCString = "2017-11-14T12:34:18.321Z"; | |||
| private DateTime SampleLastUpdatedDateTimeUTC = new DateTime(2017, 11, 14, 12, 34, 18, 321, DateTimeKind.Utc); | |||
| private const string SampleEtag = "00000000-0000-0000-0000-00000000000"; | |||
| private const string SampleCredentialPolicyName = "testCredentialPolicyName"; | |||
There was a problem hiding this comment.
Are you going to add any end to end tests as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranch.Description of the changes
Adding a new field "CredentialPolicyName" in EnrollmentGruop and IndividualEnrollment. This change will be introduced as part of 2025-07-01-preview API.
Reference/Link to the issue solved with this PR (if any)