fix(iot-dev):Fix amqp layer not handling proton:io exceptions

Server causes this error type to appear during TCP connection lost tests, so it must be a retryable exception
Azure · May 31, 2019 · d50d831 · d50d831
1 parent 295bd39
commit d50d831
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 0 deletions.
diff --git a/...ain/java/com/microsoft/azure/sdk/iot/device/transport/amqps/AmqpsExceptionTranslator.java b/...ain/java/com/microsoft/azure/sdk/iot/device/transport/amqps/AmqpsExceptionTranslator.java
@@ -91,6 +91,8 @@ static TransportException convertToAmqpException(String exceptionCode, String de
             case AmqpConnectionThrottledException.errorCode:
                 // Codes_SRS_AMQPSEXCEPTIONTRANSLATOR_28_001: [The function shall map amqp exception code "com.microsoft:device-container-throttled" to TransportException "AmqpConnectionThrottledException".]
                 return new AmqpConnectionThrottledException(description);
+            case ProtonIOException.errorCode:
+                return  new ProtonIOException(description);
             default:
                 // Codes_SRS_AMQPSEXCEPTIONTRANSLATOR_34_026: [The function shall map all other amqp exception codes to the generic TransportException "ProtocolException".]
                 return new ProtocolException(description);

diff --git a/...java/com/microsoft/azure/sdk/iot/device/transport/amqps/exceptions/ProtonIOException.java b/...java/com/microsoft/azure/sdk/iot/device/transport/amqps/exceptions/ProtonIOException.java
@@ -0,0 +1,32 @@
+package com.microsoft.azure.sdk.iot.device.transport.amqps.exceptions;
+
+import com.microsoft.azure.sdk.iot.device.exceptions.ProtocolException;
+
+public class ProtonIOException extends ProtocolException
+{
+    public static final String errorCode = "proton:io";
+
+    public ProtonIOException()
+    {
+        super();
+        this.isRetryable = true;
+    }
+
+    public ProtonIOException(String message)
+    {
+        super(message);
+        this.isRetryable = true;
+    }
+
+    public ProtonIOException(String message, Throwable cause)
+    {
+        super(message, cause);
+        this.isRetryable = true;
+    }
+
+    public ProtonIOException(Throwable cause)
+    {
+        super(cause);
+        this.isRetryable = true;
+    }
+}
diff --git a/...unit/com/microsoft/azure/sdk/iot/device/transport/amqps/AmqpsExceptionTranslatorTest.java b/...unit/com/microsoft/azure/sdk/iot/device/transport/amqps/AmqpsExceptionTranslatorTest.java
@@ -73,5 +73,6 @@ public void getConnectionStatusExceptionFromAMQPExceptionCodeReturnsExpectedMapp
         assertTrue(Deencapsulation.invoke(AmqpsExceptionTranslator.class, "convertToAmqpException", AmqpLinkRedirectException.errorCode, "") instanceof AmqpLinkRedirectException);
         assertTrue(Deencapsulation.invoke(AmqpsExceptionTranslator.class, "convertToAmqpException", AmqpConnectionThrottledException.errorCode, "") instanceof AmqpConnectionThrottledException);
         assertTrue(Deencapsulation.invoke(AmqpsExceptionTranslator.class, "convertToAmqpException", "Not a protocol standard error code", "") instanceof ProtocolException);
+        assertTrue(Deencapsulation.invoke(AmqpsExceptionTranslator.class, "convertToAmqpException", ProtonIOException.errorCode, "") instanceof ProtonIOException);
     }
 }