fix(iot-dev): Fix bug where configuration content was not serialized correctly #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly It always sent empty json objects for ModuleContent, ModulesContent, and DeviceContent even if the user provided one or more key-value pairs for it Also fix a bug where configuration values were always serialized and deserialized as floats even when they were integers
timtay-microsoft
requested review from
azabbasi,
drwill-ms,
abhipsaMisra and
brycewang-microsoft
as code owners
...t/src/main/java/com/microsoft/azure/sdk/iot/service/configurations/ConfigurationsClient.java
Show resolved
Hide resolved
...m/microsoft/azure/sdk/iot/service/configurations/serializers/ConfigurationContentParser.java
Show resolved
Hide resolved
...m/microsoft/azure/sdk/iot/service/configurations/serializers/ConfigurationContentParser.java
Show resolved
Hide resolved
...m/microsoft/azure/sdk/iot/service/configurations/serializers/ConfigurationContentParser.java
Show resolved
Hide resolved
brycewang-microsoft
approved these changes
Mar 31, 2022
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It always sent empty json objects for ModuleContent, ModulesContent, and DeviceContent even if the user provided one or more key-value pairs for it
Also fix a bug where numeric configuration values were always serialized and deserialized as floats even if they were integers