-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iot-dev): Fix bug where multiplexed devices didn't persist subscriptions if transport error occurred #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtay-microsoft
requested review from
azabbasi,
drwill-ms,
abhipsaMisra and
brycewang-microsoft
as code owners
April 7, 2022 23:53
/azp run Java Canary |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run Java Prod |
Azure Pipelines successfully started running 1 pipeline(s). |
timtay-microsoft
commented
Apr 8, 2022
.../src/main/java/com/microsoft/azure/sdk/iot/device/transport/amqps/AmqpsIotHubConnection.java
Show resolved
Hide resolved
/azp run Java Prod Basic, SDL |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run horton-java-gate |
Azure Pipelines successfully started running 1 pipeline(s). |
…iptions if transport error occurred also fix an e2e test not getting the initial twin before sending reported property updates
timtay-microsoft
force-pushed
the
timtay/fixes
branch
from
April 8, 2022 01:16
e2d4a2c
to
ff11e85
Compare
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
timtay-microsoft
commented
Apr 8, 2022
.../test/java/tests/integration/com/microsoft/azure/sdk/iot/iothub/MultiplexingClientTests.java
Show resolved
Hide resolved
timtay-microsoft
commented
Apr 8, 2022
.../test/java/tests/integration/com/microsoft/azure/sdk/iot/iothub/MultiplexingClientTests.java
Show resolved
Hide resolved
brycewang-microsoft
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix an e2e test not getting the initial twin before sending reported property updates