Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guava upgrade #1529

Merged
merged 15 commits into from
Apr 18, 2022
Merged

Guava upgrade #1529

merged 15 commits into from
Apr 18, 2022

Conversation

timtay-microsoft
Copy link
Member

@timtay-microsoft timtay-microsoft commented Apr 12, 2022

Adding a proxy implementation to our code so that we can make some modifications so it is compatible with more recent guava versions. For the most part, this proxy implementation is equivalent to the dependency we previously took

All this proxy code now lives in the "tests/integration/com/microsoft/azure/sdk/iot/helpers/proxy" path.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot Apr 15, 2022
@Azure Azure deleted a comment from azure-pipelines bot Apr 15, 2022
@Azure Azure deleted a comment from azure-pipelines bot Apr 15, 2022
@Azure Azure deleted a comment from azure-pipelines bot Apr 15, 2022
@Azure Azure deleted a comment from azure-pipelines bot Apr 15, 2022
@Azure Azure deleted a comment from azure-pipelines bot Apr 15, 2022
@Azure Azure deleted a comment from azure-pipelines bot Apr 15, 2022
Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than changing the guava dependency version, was there any other change required in the code that was copied over? Also, do we have the original sourcecode location documented somewhere so that we have a reference location to look at for any issues/updates etc. (if any)?

Copy link
Contributor

@drwill-ms drwill-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the caveat that add more documentation about where we got the code from, why we copied it, what the license is, that we only use it for testing, etc.

@timtay-microsoft
Copy link
Member Author

Other than changing the guava dependency version, was there any other change required in the code that was copied over? Also, do we have the original sourcecode location documented somewhere so that we have a reference location to look at for any issues/updates etc. (if any)?

There are some small changes made, so I've included a link to the Github repo that has the original source code.

@timtay-microsoft
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants