-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guava upgrade #1529
Guava upgrade #1529
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
f12b61b
to
95207e6
Compare
This reverts commit 8c17063.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than changing the guava dependency version, was there any other change required in the code that was copied over? Also, do we have the original sourcecode location documented somewhere so that we have a reference location to look at for any issues/updates etc. (if any)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the caveat that add more documentation about where we got the code from, why we copied it, what the license is, that we only use it for testing, etc.
There are some small changes made, so I've included a link to the Github repo that has the original source code. |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Adding a proxy implementation to our code so that we can make some modifications so it is compatible with more recent guava versions. For the most part, this proxy implementation is equivalent to the dependency we previously took
All this proxy code now lives in the "tests/integration/com/microsoft/azure/sdk/iot/helpers/proxy" path.