fix(iot-dev): Fix unnecessary creation of custom symbol instances in amqp layer #1541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each new symbol instance is saved within proton-j's symbol cache. This cache lives as long as the proton-j reactor itself and cannot be manually cleared. That means that a multiplexed connection that is never closed and that has an infinite number of devices added and removed over time would cause the symbol cache to grow infinitely.
With this change, the only symbols in the symbol cache will be the constants used as property keys when building the amqp connection/sessions/links like the below:
#1478