Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(all): update Gson dependency in main pom #1557

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

brycewang-microsoft
Copy link
Collaborator

Not exactly for Gson-related dependabot alerts here, as we are using patched version 2.8.9 already. The security alerts were triggered as dependabot could not determine the currently installed version.

@brycewang-microsoft
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security alerts were triggered as dependabot could not determine the currently installed version.

Do we know how we can get dependabot to pick up the correct version?

@brycewang-microsoft
Copy link
Collaborator Author

The security alerts were triggered as dependabot could not determine the currently installed version.

Do we know how we can get dependabot to pick up the correct version?

Good question! I haven't got an answer for this but my guess is that dependabot cannot find the version of dependency (in children pom) which is inherited from the parent pom. I will reach out to dependabot-core for some insights on this.

@brycewang-microsoft brycewang-microsoft merged commit 2e2baf0 into main Jun 3, 2022
@brycewang-microsoft brycewang-microsoft deleted the gson_patch branch June 3, 2022 17:09
brycewang-microsoft added a commit to brycewang-microsoft/azure-iot-sdk-java that referenced this pull request Jun 3, 2022
brycewang-microsoft added a commit to brycewang-microsoft/azure-iot-sdk-java that referenced this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants