Getter setter for twin fields #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added getter/setter for missing Twin fields reported by customer (reported using Ava: 2206170060000042) Also updated unit test:: testQueryTwins() to validate the fields.
updated data type for cloudToDeviceMessageCount from String to Integer
tmahmood-microsoft
requested review from
timtay-microsoft,
drwill-ms,
abhipsaMisra,
andyk-ms and
brycewang-microsoft
as code owners
|
/azp run |
|
Pull request contains merge conflicts. |
|
/azp run |
|
Pull request contains merge conflicts. |
|
/azp run |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Can you add a step to an existing e2e test that checks that this value is not null when it calls |
timtay-microsoft
approved these changes
Jul 1, 2022
|
Updated e2e test to check CloudToDeviceMessageCount is not null |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranch.Reference/Link to the issue solved with this PR (if any)
Description of the problem
Description of the solution