fix(iot-device): fix issue with direct method after reconnect from temporary network disconnect - AMQP #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mporary network disconnect - AMQP DeviceClient doesn't fully reconnect after temporary network disconnect (AMQP), attempts to invoke direct method fails. Removed unnecessary boolean which were intended to carry over state between reconnection. With each reconnection, we instantiate new SessionHandler but only set the boolean to true (and create method/twin links) when sending first message during initial connection, thus during reconnection we never create method/twin links.
tmahmood-microsoft
requested review from
timtay-microsoft,
drwill-ms,
abhipsaMisra,
andyk-ms and
brycewang-microsoft
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
...nt/src/main/java/com/microsoft/azure/sdk/iot/device/transport/amqps/AmqpsSessionHandler.java
Outdated
Show resolved
Hide resolved
…isconnect - AMQP reverting changes to AmqpsSessionHandler (e3558d2) and making sure after closing amqp connection due to transport error, we save previous AmqpsSessions so that their twin/methods subscriptions can persist.
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
timtay-microsoft
approved these changes
Jul 21, 2022
Yes, I was able to test locally and confirm that SDK recovers subscriptions as we do not lose SessionHandler object |
Perfect. Then you are all good to merge. |
This was referenced Jul 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeviceClient doesn't fully reconnect after temporary network disconnect (AMQP), attempts to invoke direct method fails.
Removed unnecessary boolean which were intended to carry over state between reconnection.
With each reconnection, we instantiate new SessionHandler but only set the boolean to true (and create method/twin links) when sending first message during initial connection, thus during reconnection we never create method/twin links.
github issue: #1571
Checklist
mainbranch.Reference/Link to the issue solved with this PR (if any)
Description of the problem
Description of the solution