Added Automatic-Module-Name to jar manifests for Modular Java #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrogerWalt
requested review from
timtay-microsoft,
drwill-ms,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms,
patilsnr and
schoims
as code owners
|
@timtay-microsoft Could someone please look at this PR? I have a Modular Java 18 app, and I'm trying to connect it to Azure IoT Hub, but all the libraries are missing Module Names. (I have also fixed this for the Application Insights Java runtime attach library and it has already been approved, I just need these approved and merged as well to continue development of the project.) Please review and approve so I can begin using these libraries. Thanks! |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Sorry for the delay. Sure, this looks fine to me. |
timtay-microsoft
approved these changes
Nov 30, 2022
No worries, thanks! |
|
We'll try to get a release out including this change in the next week or two, FYI |
|
Awesome, thanks for the quick turn-around @timtay-microsoft ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranch.Reference/Link to the issue solved with this PR (if any)
Description of the problem
I am building Modular Java 18 apps. When I add one or more of these libraries, it breaks my build because the library does not have a module that I can import.
Description of the solution
By adding the Automatic-Module-Name to the jar Manifest, people writing modular Java will still be able to use the libraries without preventing those still on Java 8 from using them. I have made this change in other Azure projects to allow Modular support.
*No tests changes were made, because the changes to the build file should not affect the code, only adding a line to the manifests that will allow them to work with Modular Java.