Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some threading issues with correlation callback maps #1719

Merged
merged 7 commits into from
May 31, 2023
Merged

Fix some threading issues with correlation callback maps #1719

merged 7 commits into from
May 31, 2023

Conversation

timtay-microsoft
Copy link
Member

@timtay-microsoft timtay-microsoft commented May 26, 2023 •
edited
Loading

  • Make correlation callback cleanup job run less frequently
    • Previously ran several times per second. Now runs once per hour
  • Make correlation callback operation blocks atomic
    • We don't want cases where one thread is calling callbacks.get("some id") while another just removed that entry.

#1718

@timtay-microsoft
refactor(iot-dev): Make correlation callback cleanup job run less fre…
df23e5b 
…quently

It used to run a few times every second, now it runs once an hour
@timtay-microsoft
fix(iot-dev): Make correlation callback cleanup/get operations atomic
39db978 
We don't want cases where one thread is calling callbacks.get("some id") while another just removed that entry.

#1718
@timtay-microsoft
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@timtay-microsoft
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@timtay-microsoft
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@timtay-microsoft
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@timtay-microsoft
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@timtay-microsoft timtay-microsoft merged commit e438f2e into main May 31, 2023
@timtay-microsoft timtay-microsoft deleted the timtay/fix branch May 31, 2023 18:54
@timtay-microsoft timtay-microsoft mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycewang-microsoft brycewang-microsoft brycewang-microsoft approved these changes

@drwill-ms drwill-ms Awaiting requested review from drwill-ms

@abhipsaMisra abhipsaMisra Awaiting requested review from abhipsaMisra abhipsaMisra is a code owner

@andyk-ms andyk-ms Awaiting requested review from andyk-ms andyk-ms is a code owner

@tmahmood-microsoft tmahmood-microsoft Awaiting requested review from tmahmood-microsoft tmahmood-microsoft is a code owner

@patilsnr patilsnr Awaiting requested review from patilsnr patilsnr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtay-microsoft @brycewang-microsoft