Fixing issue: QOS not set for incoming messages from $iothub/twin/PAT…

[dzakub]

…CH/properties/desired/ topic #1746

Checklist

• I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-java/blob/main/.github/CONTRIBUTING.md).
• I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
• I submitted this PR against the correct branch:
• This pull-request is submitted against the main branch.

Reference/Link to the issue solved with this PR (if any)

#1746

Description of the problem

Problem is described in the issue.

Description of the solution

Added code to copy QOS from original message.

[dzakub]

@microsoft-github-policy-service agree

[timtay-microsoft]

This change seems reasonable, but these messages always have a QoS of 0, so I'm not sure what change in behavior you'll see from this. Are you expecting QoS other than 0 here?

[dzakub]

This change seems reasonable, but these messages always have a QoS of 0, so I'm not sure what change in behavior you'll see from this. Are you expecting QoS other than 0 here?

I didn't know that IOT hub sends always massages with QOS 0 here. If there will be no change in behavior.
I discovered this 'issue' whlie stubbing iot hub for integration tests that were written to document behavior of 1.x clients and to ease upgrading to 2.x.
Tests were green for 1.x, but started failing after upgrade to 2.x. After investigation I discovered mentioned problem (my fake iot hub was sending messages with QOS 1)

[timtay-microsoft]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[timtay-microsoft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).