Remove unused (and unavailable) InactiveGroupException import statement that breaks the build. #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt that breaks the build.
|
This import statement was added as part of the following commit: b60a121 |
prmathur-microsoft
approved these changes
Jan 23, 2018
|
What's the process of getting this merged - do you wait until a build completes or something similar? Thanks! |
|
Yes. We run builds sequentially on our internal CI system which is gated and runs several tests. And only if the tests pass, your check in gets through. Currently I have kicked a run for your PR, waiting for it to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
import sun.rmi.server.InactiveGroupExceptionstatement is added to DeviceTwin but the class is not used. This is fortunate as under JDK 9 this fails to compile. This PR removes this import and restores the ability to build this project under JDK 9.