Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the class name of a sample #223

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

vjrantal
Copy link
Contributor

@vjrantal vjrantal commented Apr 9, 2018

Without the fix, running this sample would fail to an error like:
Could not find or load main class

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-java/blob/master/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the master branch.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

To reproduce without the fix:

cd azure-iot-sdk-java/device/iot-device-samples/transportclient-sample
mvn install -DskipTests
java -jar ~/.m2/repository/com/microsoft/azure/sdk/iot/samples/device/transportclient-sample/1.9.0/transportclient-sample-1.9.0-with-deps.jar
Error: Could not find or load main class samples.com.microsoft.azure.sdk.iot.MultiplexingSample

Description of the solution

The solution is to fix the class name to match what is defined in the source file.

Without the fix, running this sample would fail to an error like:
`Could not find or load main class`
@timtay-microsoft
Copy link
Member

Looks good to me. I'm looking to get this merged in now.

@vjrantal Thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey.

@az-iot-builder-01 az-iot-builder-01 merged commit 8fca5a5 into Azure:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants