Removing incorrectly-added import statement #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`import com.sun.org.apache.bcel.internal.generic.RET;` was added to `SendMessagesCommon`, breaking the build when run under JDK 9, as the `RET` class is not exposed as public API in the module. It also turns out that this class is not used in `SendMessagesCommon`, so removing the import does not appear to result in any issue.
JonathanGiles
added a commit
to JonathanGiles/azure-javadocs
that referenced
this pull request
Apr 17, 2018
Now that Azure/azure-iot-sdk-java#226 is merged, IOT can be enabled again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import com.sun.org.apache.bcel.internal.generic.RET;was added toSendMessagesCommon, breaking the build when run under JDK 9, as theRETclass is not exposed as public API in the module. It also turns out that this class is not used inSendMessagesCommon, so removing the import does not appear to result in any issue.