Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging applied to more areas #27

Merged
merged 5 commits into from
Jan 27, 2017
Merged

Conversation

azmigproject
Copy link

No description provided.

Vijendra added 2 commits January 24, 2017 20:53
Logging applied to more areas
Logging applied to more areas
@msftclas
Copy link

Hi @azmigproject, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@prmathur-microsoft
Copy link
Member

Please add more logging in -
To figure out further we will need more logging in the following functions in AmqpsIotHubConnection and transport.

  1. sendMessage – please get as detailed as possible especially around send and encode. I believe the problem may be around this code.
  2. onLinkflow
  3. onDelivery – please clearly indicate the arrival of the message.
  4. invokeCallbacks from transport – indicate successful completion of this callback.
  5. sendMessageResult – please indicate the result (complete ?, error ?)
  6. handleMessage – indicate arrival of message and content
  7. messageSent – indicate success clearly and log failure indicating the reason.

@prmathur-microsoft prmathur-microsoft self-assigned this Jan 24, 2017
@prmathur-microsoft prmathur-microsoft self-requested a review January 24, 2017 21:54
Vijendra added 2 commits January 25, 2017 22:37
Updated logs per feedback
Indentation corrected
@@ -354,15 +354,17 @@ public Integer sendMessage(Message message)
byte[] tag = String.valueOf(this. nextTag++).getBytes();
Delivery dlv = sender.delivery(tag);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add logging on line 345 just before breaking that encoding is complete ? I suspect the issue is somewhere in this block.

@prmathur-microsoft
Copy link
Member

Also, can you please sign the CLA for this request to get in.

@prmathur-microsoft prmathur-microsoft dismissed their stale review January 26, 2017 03:06

Please sign CLA before merging.

logging added to message encoding area
@msftgits
Copy link

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Jan 27, 2017
@msftgits msftgits reopened this Jan 27, 2017
@msftclas
Copy link

Hi @azmigproject, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@prmathur-microsoft prmathur-microsoft merged commit bf1d13c into Azure:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants